[Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

Dylan Baker dylan at pnwbakers.com
Mon Nov 13 17:41:09 UTC 2017


I thought I'd fixed this already,
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Quoting Jon Turney (2017-11-13 02:28:27)
> It's ok to use an empty list for dependencies:, but it's not ok to try to
> use the found() method of it.
> 
> See also https://github.com/mesonbuild/meson/issues/2324
> 
> Signed-off-by: Jon Turney <jon.turney at dronecode.org.uk>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 0cbaefb7882..9b0e495a58c 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -925,7 +925,7 @@ endif
>  if dep_m.found()
>    gl_priv_libs += '-lm'
>  endif
> -if dep_dl.found()
> +if dep_dl != [] and dep_dl.found()
>    gl_priv_libs += '-ldl'
>  endif
>  
> -- 
> 2.15.0
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171113/1b4c74c3/attachment.sig>


More information about the mesa-dev mailing list