[Mesa-dev] [PATCH 04/11] intel/tools/error: Only decode a few sections of error states.

[Kenneth Graunke]

On Sunday, November 12, 2017 1:41:29 AM PST Chris Wilson wrote:
> Quoting Kenneth Graunke (2017-11-12 08:35:05)
> > These three are the only we can reasonably decode with genxml.
> 
> Makes sense, I would recommend putting those into an array for ease of
> future expansion. Maybe also strcasecmp?
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Yeah, that's not a bad idea.  I'll write a patch for that.

> (Note to self, aubinator will be specialiased for debugging mesa hangs;
> leaving a niche for intel_error_decode for triaging.)
> -Chris

Why do you say that?  I would like it to be generally useful for all
hangs.  We just don't want to try and use genxml to decode things that
aren't GPU commands or structures, as that will print garbage.

We probably do want to port over a "decoder" that just prints the raw
hex values for unknown sections, like intel_error_decode does.  We
probably ought to also add pretty-printers for the other sections.

We also ought to improve the decoding of the hardware context image.
Likely the best way is to add a genxml structure type for the entire
logical context image, and then use that when decoding.

I'd be happy to see non-Mesa-related improvements made to
aubinator_error_decode.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171113/497f9688/attachment.sig>