[Mesa-dev] [PATCH] meson: if dep_dl is an empty list, it's not a dependency object

Dylan Baker dylan at pnwbakers.com
Tue Nov 14 21:46:51 UTC 2017


Quoting Jon Turney (2017-11-14 04:05:21)
> On 13/11/2017 17:41, Dylan Baker wrote:
> > I thought I'd fixed this already,
> > Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
> 
> This workaround is already in place for dep_xxf86vm.
> 
> I took a brief look, and didn't see anywhere the same problem could 
> occur with any of the other uses of [] for a dependency.
> 
> > Quoting Jon Turney (2017-11-13 02:28:27)
> >> It's ok to use an empty list for dependencies:, but it's not ok to try to
> >> use the found() method of it.

Ah that makes sense. Once we bump our minimum version so that the empty
dependency() doesn't generate console noise (I think you did that work?) I'd
like to switch to that.

You have commit access, correct?

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171114/9ec4950b/attachment.sig>


More information about the mesa-dev mailing list