[Mesa-dev] [PATCH 1/2] tgsi: s/unsigned/enum tgsi_texture_type/

Charmaine Lee charmainel at vmware.com
Wed Nov 15 00:37:32 UTC 2017


>From: Brian Paul <brianp at vmware.com>
>Sent: Tuesday, November 14, 2017 3:42 PM
>To: mesa-dev at lists.freedesktop.org
>Cc: Charmaine Lee; Neha Bhende
>Subject: [PATCH 1/2] tgsi: s/unsigned/enum tgsi_texture_type/
...

>diff --git a/src/gallium/auxiliary/tgsi/tgsi_util.h b/src/gallium/auxiliary/tgsi/tgsi_util.h
>index 534b5f7..6d56c5b 100644
>--- a/src/gallium/auxiliary/tgsi/tgsi_util.h
>+++ b/src/gallium/auxiliary/tgsi/tgsi_util.h
>@@ -82,24 +82,24 @@ struct tgsi_src_register
> tgsi_util_get_src_from_ind(const struct tgsi_ind_register *reg);

> int
>-tgsi_util_get_texture_coord_dim(unsigned tgsi_tex);
>+tgsi_util_get_texture_coord_dim(enum tgsi_texture_type tgsi_tex);

> int
>-tgsi_util_get_shadow_ref_src_index(unsigned tgsi_tex);
>+tgsi_util_get_shadow_ref_src_index(enum tgsi_texture_type tgsi_tex);

> boolean
>-tgsi_is_shadow_target(unsigned target);
>+tgsi_is_shadow_target(enum tgsi_texture_type);

Lets add the argument name "target" back to be consistent with the rest.

Other than that, this series looks good to me.

Reviewed-by: Charmaine Lee <charmainel at vmware.com>



More information about the mesa-dev mailing list