[Mesa-dev] [PATCH] r600: shader CF_OP_VTX also doesn't use the EOP bit.

Dave Airlie airlied at gmail.com
Wed Nov 15 01:28:09 UTC 2017


On 15 November 2017 at 04:50, Gert Wollny <gw.fossdev at gmail.com> wrote:
> Although the EOP bit is documented for the vertex fetch clause, it is not
> properly interpreted. As a result the piglit
>   spec/arb_tessellation_shader/execution/trivial-tess-gs_no-gs-inputs
> creates a TESS_EVAL shader that does not have an EOP clause, which might
> result in a GPU lockup.
>
> This patch forces an additional CF_OP_NOP group like it is already done for
> other final CF_OP groups.

Although I think this is probably a good safety thing to add, I've
sent a patch that should
make it unneeded, it would be good if you could test it.

https://patchwork.freedesktop.org/series/33847/

I'll likely apply this as well at some point, that test however hangs
my cayman with or
without my patch (and your patch doesn't do anything on cayman).

Dave.


More information about the mesa-dev mailing list