[Mesa-dev] [Bug 103757] eglGetDisplay() is broken for Wayland

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Nov 15 15:31:03 UTC 2017


https://bugs.freedesktop.org/show_bug.cgi?id=103757

--- Comment #5 from Daniel Stone <daniel at fooishbar.org> ---
(In reply to Emil Velikov from comment #4)
> <cheeky>
> I do recall mentioning that exposing the same symbol(s) will lead to bad
> experiences. Followed by some ideas...
> </cheeky>

Yep, as per the discussion on inlining wayland_drm_buffer_get. :)

It certainly hurts, but then again breaking ABI and forcing every single
Wayland user to rebuild - probably having to change every symbol name in the
API to make sure there was no clash between the two when loaded - would be
uncharted depths of pain.

On the other hand, the solution is the same: look at the interface name, rather
than ever compare pointers equally. Unfortunately, we can't use the same
solution since the wayland-drm one only works for wl_resource in
libwayland-server rather than a plain wl_interface or a wl_proxy ... oh well.

> A better heuristic would be to use dladdr() for eglGetDisplay. See the
> analogous GBM patch [1].

I don't think that would necessarily fix it, particularly if the
wayland-client.so.1 being loaded differed, e.g. due to people linking their own
copies?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171115/6e16fc41/attachment.html>


More information about the mesa-dev mailing list