[Mesa-dev] [PATCH] radv: inline radv_upload_{compute, graphics}_shader_descriptors()

[Bas Nieuwenhuizen]

I suspect this doesn't do what you'd expect. IIRC specifying online in a
function in a .c file is pretty much useless because it only changes
linking mode, not actually online's it.

On 15 Nov 2017 15:43, "Samuel Pitoiset" <samuel.pitoiset at gmail.com> wrote:

> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_
> buffer.c
> index 18503cd513..146dcf439f 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -1830,7 +1830,7 @@ radv_cmd_buffer_update_vertex_descriptors(struct
> radv_cmd_buffer *cmd_buffer, bo
>         return true;
>  }
>
> -static bool
> +static inline bool
>  radv_upload_graphics_shader_descriptors(struct radv_cmd_buffer
> *cmd_buffer, bool pipeline_is_dirty)
>  {
>         if (!radv_cmd_buffer_update_vertex_descriptors(cmd_buffer,
> pipeline_is_dirty))
> @@ -3584,7 +3584,7 @@ radv_emit_dispatch_packets(struct radv_cmd_buffer
> *cmd_buffer,
>         assert(cmd_buffer->cs->cdw <= cdw_max);
>  }
>
> -static void
> +static inline void
>  radv_upload_compute_shader_descriptors(struct radv_cmd_buffer
> *cmd_buffer)
>  {
>         radv_flush_descriptors(cmd_buffer, VK_SHADER_STAGE_COMPUTE_BIT);
> --
> 2.15.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171116/348d4a84/attachment.html>