[Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

[Lucas Stach]

Am Mittwoch, den 15.11.2017, 19:55 +0100 schrieb Wladimir J. van der
Laan:
> > Sorry for noticing before, but this breaks glmark2 texture. I
> > didn't
> > yet dig into the issue but it's definitely caused by this commit.
> > 
> > To reproduce, simply run
> > glmark2-es2-drm -b texture:texture-filter=mipmap
> 
> That's weird, as that neither uses point sprites nor flat shading.
> 
> I'll have a look...

I think the issue is the mipmap generation. The blitter used to do that
is using flatshading, but probably doesn't declare the textcoord
varyings as TGSI_SEMANTIC_TEXCOORD but TGSI_SEMANTIC_GENERIC instead.

It seems this is legal, so we can't rely on texcoord varyings being
declared with TGSI_SEMANTIC_TEXCOORD...

This means we really need to make the varying use a derived state
depending on the primitive. Or maybe we can just scan the input
varyings and if we find a PCOORD varying assume that we are going to
render points, but I don't know if this assumption holds for all cases.

Regards,
Lucas