[Mesa-dev] [PATCH] genxml: Fix PIPELINE_SELECT on G45/Ironlake.

[Lionel Landwerlin]

We've establish over IRC that I was confused by the documentation (also 
some of it isn't accurate :( )

On 16/11/17 08:36, Kenneth Graunke wrote:
> Original 965 sets bits 28:27 to 0, while G45 and later set it to 1.
>
> Also, there's no GPGPU pipeline on Gen5, and the pipeline to select
> is a single bit - bit 1 is reserved.
> ---
>   src/intel/genxml/gen45.xml | 4 ++--
>   src/intel/genxml/gen5.xml  | 5 ++---
>   2 files changed, 4 insertions(+), 5 deletions(-)
>
> We don't actually use this in i965 today, but we do use it when
> decoding batches in INTEL_DEBUG=bat or aubinator_error_decode...
>
> diff --git a/src/intel/genxml/gen45.xml b/src/intel/genxml/gen45.xml
> index c91085831ea..f74a40202fc 100644
> --- a/src/intel/genxml/gen45.xml
> +++ b/src/intel/genxml/gen45.xml
> @@ -1162,10 +1162,10 @@
>   
>     <instruction name="PIPELINE_SELECT" bias="1" length="1">
>       <field name="Command Type" start="29" end="31" type="uint" default="3"/>
> -    <field name="Command SubType" start="27" end="28" type="uint" default="0"/>
> +    <field name="Command SubType" start="27" end="28" type="uint" default="1"/>
>       <field name="3D Command Opcode" start="24" end="26" type="uint" default="1"/>
>       <field name="3D Command Sub Opcode" start="16" end="23" type="uint" default="4"/>
> -    <field name="Pipeline Selection" start="0" end="1" type="uint">
> +    <field name="Pipeline Selection" start="0" end="0" type="uint">
>         <value name="3D" value="0"/>
>         <value name="Media" value="1"/>
>       </field>
> diff --git a/src/intel/genxml/gen5.xml b/src/intel/genxml/gen5.xml
> index 93e687a32bd..8fdac7cd55a 100644
> --- a/src/intel/genxml/gen5.xml
> +++ b/src/intel/genxml/gen5.xml
> @@ -1253,13 +1253,12 @@
>   
>     <instruction name="PIPELINE_SELECT" bias="1" length="1">
>       <field name="Command Type" start="29" end="31" type="uint" default="3"/>
> -    <field name="Command SubType" start="27" end="28" type="uint" default="0"/>
> +    <field name="Command SubType" start="27" end="28" type="uint" default="1"/>
>       <field name="3D Command Opcode" start="24" end="26" type="uint" default="1"/>
>       <field name="3D Command Sub Opcode" start="16" end="23" type="uint" default="4"/>

With the part below dropped :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

> -    <field name="Pipeline Selection" start="0" end="1" type="uint">
> +    <field name="Pipeline Selection" start="0" end="0" type="uint">
>         <value name="3D" value="0"/>
>         <value name="Media" value="1"/>
> -      <value name="GPGPU" value="2"/>
>       </field>
>     </instruction>
>