[Mesa-dev] [PATCH] llvmpipe: fix snorm blending

[Roland Scheidegger]

Am 17.11.2017 um 14:20 schrieb Emil Velikov:
> Hi Roland,
> 
> Just a small fly-by idea:
> 
> On 17 November 2017 at 07:00,  <sroland at vmware.com> wrote:
> 
>> -   if(bld->type.norm) {
>> +   if(type.norm) {
>>        const char *intrinsic = NULL;
>>
>> -      if(a == bld->one || b == bld->one)
>> +      if(!type.sign && (a == bld->one || b == bld->one))
>>          return bld->one;
>>
>>        if (!type.floating && !type.fixed) {
>> @@ -849,10 +849,10 @@ lp_build_sub(struct lp_build_context *bld,
>>     if(a == b)
>>        return bld->zero;
>>
>> -   if(bld->type.norm) {
>> +   if(type.norm) {
>>        const char *intrinsic = NULL;
>>
>> -      if(b == bld->one)
>> +      if(!type.sign && b == bld->one)
>>          return bld->zero;
>>
> One could fix the coding style (aka missing space between if and
> opening bracket) in the above code, while they're here?
> 

Ah yes, I'll fix that. (There's so many of these in that file that I
didn't even notice it was wrong...)

Roland