[Mesa-dev] [PATCH 1/4] radv: remove useless check in radv_set_depth_clear_regs()

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Sun Nov 19 14:11:36 UTC 2017


The series is

Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Wed, Nov 15, 2017 at 3:43 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> aspects can't be zero and there is an assertion that ensures
> it's not in emit_clear().
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index 146dcf439f..0502be1a93 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -1299,7 +1299,7 @@ radv_set_depth_clear_regs(struct radv_cmd_buffer *cmd_buffer,
>         va += image->offset + image->clear_value_offset;
>         unsigned reg_offset = 0, reg_count = 0;
>
> -       if (!image->surface.htile_size || !aspects)
> +       if (!image->surface.htile_size)
>                 return;
>
>         if (aspects & VK_IMAGE_ASPECT_STENCIL_BIT) {
> --
> 2.15.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list