[Mesa-dev] [PATCH] intel: fix diasm_info memory leaks

Tapani Pälli tapani.palli at intel.com
Mon Nov 20 09:00:13 UTC 2017


Fixes: 4f82b1728719 ("i965: Rewrite disassembly annotation code")
Cc: Matt Turner <mattst88 at gmail.com>
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
---
 src/intel/compiler/brw_fs_generator.cpp   | 2 +-
 src/intel/compiler/brw_vec4_generator.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/intel/compiler/brw_fs_generator.cpp b/src/intel/compiler/brw_fs_generator.cpp
index 4984fb83d6..28790c86a6 100644
--- a/src/intel/compiler/brw_fs_generator.cpp
+++ b/src/intel/compiler/brw_fs_generator.cpp
@@ -2215,8 +2215,8 @@ fs_generator::generate_code(const cfg_t *cfg, int dispatch_width)
               100.0f * (before_size - after_size) / before_size);
 
       dump_assembly(p->store, disasm_info);
-      ralloc_free(disasm_info);
    }
+   ralloc_free(disasm_info);
    assert(validated);
 
    compiler->shader_debug_log(log_data,
diff --git a/src/intel/compiler/brw_vec4_generator.cpp b/src/intel/compiler/brw_vec4_generator.cpp
index 0567190473..8e11754e02 100644
--- a/src/intel/compiler/brw_vec4_generator.cpp
+++ b/src/intel/compiler/brw_vec4_generator.cpp
@@ -2203,8 +2203,8 @@ generate_code(struct brw_codegen *p,
               100.0f * (before_size - after_size) / before_size);
 
       dump_assembly(p->store, disasm_info);
-      ralloc_free(disasm_info);
    }
+   ralloc_free(disasm_info);
    assert(validated);
 
    compiler->shader_debug_log(log_data,
-- 
2.14.3



More information about the mesa-dev mailing list