[Mesa-dev] [PATCH 3/3] glx/dri3: Fix passing renderType into glXCreateContext

Andres Gomez agomez at igalia.com
Mon Nov 20 16:13:05 UTC 2017


Hi Adam,

This fix is causing the following regression in master (and in the
stable 17.2 queue, if cherry-picked):
https://bugs.freedesktop.org/show_bug.cgi?id=103825

Hence, I'm leaving it out until the regression is cleared (either with
a fix in mesa or by clarifying whether it is a false positive).

Thanks!

On Thu, 2017-11-09 at 16:57 -0500, Adam Jackson wrote:
> Without this, trying to create a GLX_RGBA_FLOAT_TYPE_ARB context would
> fail, because GLX_RGBA_TYPE would be a mismatch with the fbconfig.
> 
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  src/glx/dri3_glx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c
> index fa048f990a..a10306fe32 100644
> --- a/src/glx/dri3_glx.c
> +++ b/src/glx/dri3_glx.c
> @@ -324,9 +324,10 @@ dri3_create_context(struct glx_screen *base,
>                      struct glx_context *shareList, int renderType)
>  {
>     unsigned int error;
> +   uint32_t attribs[2] = { GLX_RENDER_TYPE, renderType };
>  
>     return dri3_create_context_attribs(base, config_base, shareList,
> -                                      0, NULL, &error);
> +                                      1, attribs, &error);
>  }
>  
>  static void
-- 
Br,

Andres


More information about the mesa-dev mailing list