[Mesa-dev] [PATCH v5 07/13] meson: extend install_megadrivers script to handle symmlinking

Dylan Baker dylan at pnwbakers.com
Tue Nov 21 17:54:16 UTC 2017


Quoting Eric Engestrom (2017-11-21 02:39:44)
> On Monday, 2017-11-20 11:09:39 -0800, Dylan Baker wrote:
> > Which is required for the gallium media state trackers.
> > 
> > v4: - Make the full version the hard link and the partial so versiions
> >       the symlinks
> > v5: - drop --so-version all-together. Instead pass the full name of the
> >       DSO and the script will automatically generate the appropriate
> >       symlinks as necessary.
> 
> I'm ok with this solution :)
> One typo in the commit title ("symmlinking" s/mm/m/), but this patch and
> patch 8/13 are:
> Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> 
> (sorry for being a bit of a pain with the previous revisions of this patch)
> 
> I had a look at the rest of the series and didn't notice anything wrong,
> but that's not an actual review.
> 

No worries, I'd rather have people reviewing my patches and forcing me to make
things better than ignoring them.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171121/dc57eaec/attachment.sig>


More information about the mesa-dev mailing list