[Mesa-dev] [PATCH v2] meson: add logic to select apple and windows dri

Dylan Baker dylan at pnwbakers.com
Tue Nov 21 18:50:29 UTC 2017


Quoting Eric Engestrom (2017-11-21 10:38:25)
> On Tuesday, 2017-11-21 10:21:07 -0800, Dylan Baker wrote:
> > This is still not fully correct (haiku and BSD is notably probably not
> > correct), but Linux is not regressed and this should be correct for
> > macOS and Windows.
> > 
> > v2: - set the dri_platform to windows on Cygwin as well (Jon)
> 
> R-b stands
> 
> > 
> > Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> > ---
> >  meson.build | 15 +++++++++++++--
> >  1 file changed, 13 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index 52f2c1cb0d0..4248cbcfd7e 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -187,8 +187,19 @@ if with_dri_i915
> >    dep_libdrm_intel = dependency('libdrm_intel', version : '>= 2.4.75')
> >  endif
> >  
> > -# TODO: other OSes
> > -with_dri_platform = 'drm'
> > +# TODO: gnu 
> 
> I missed that comment the first time around; I don't understand what it
> means?

The autotools build has a handlers for setting the dri_platform to 'none' on
gnu* (which I assume to be hurd). See configure.ac:1513

As far as I know meson doesn't support hurd ATM (though I doubt they'd turn away
patches for it).

We can drop the TODO if you'd prefer, I just like to note things in the
autotools/scons build that aren't currently supported in the meson build.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171121/6c01fcce/attachment.sig>


More information about the mesa-dev mailing list