[Mesa-dev] [PATCH 15/15] radeonsi: enable gs support for nir backend

[Timothy Arceri]

On 23/11/17 00:24, Ilia Mirkin wrote:
> On Wed, Nov 22, 2017 at 5:30 AM, Timothy Arceri <tarceri at itsqueeze.com> wrote:
>> ---
>>   src/gallium/drivers/radeonsi/si_pipe.c       |  3 ++-
>>   src/gallium/drivers/radeonsi/si_shader_nir.c | 10 ++++++++--
>>   src/mesa/state_tracker/st_glsl_to_nir.cpp    | 12 ++++++++++++
>>   3 files changed, 22 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c
>> index b3d8ae508b..dffdab5d41 100644
>> --- a/src/gallium/drivers/radeonsi/si_pipe.c
>> +++ b/src/gallium/drivers/radeonsi/si_pipe.c
>> @@ -542,21 +542,21 @@ static int si_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>>          case PIPE_CAP_CONSTANT_BUFFER_OFFSET_ALIGNMENT:
>>          case PIPE_CAP_TEXTURE_BUFFER_OFFSET_ALIGNMENT:
>>          case PIPE_CAP_MAX_TEXTURE_GATHER_COMPONENTS:
>>          case PIPE_CAP_MAX_STREAM_OUTPUT_BUFFERS:
>>          case PIPE_CAP_MAX_VERTEX_STREAMS:
>>          case PIPE_CAP_SHADER_BUFFER_OFFSET_ALIGNMENT:
>>                  return 4;
>>
>>          case PIPE_CAP_GLSL_FEATURE_LEVEL:
>>                  if (sscreen->b.debug_flags & DBG(NIR))
>> -                       return 140; /* no geometry and tessellation shaders yet */
>> +                       return 150; /* no tessellation shaders yet */
> 
> 330 presumably?

The thing is that even though the GLSL version doesn't support tess the 
extension is actually enable as we don't have (and shouldn't bother 
implementing) a different extension table for the tgsi and nir backends. 
Just bumping this to 150 causes a bunch of tess piglit test to start 
running (and crashing). I'd rather just keep this at 150 for now until I 
can fix more bugs and enable tess support.