[Mesa-dev] [PATCH 01/20] mesa: replace GLenum with GLenum16 in common structures (v2)

Fredrik Höglund fredrik at kde.org
Thu Nov 23 00:32:57 UTC 2017


On Wednesday 22 November 2017, Ian Romanick wrote:
> There are a couple small nits below.
> 
> I haven't reviewed this with the rigor that I would like because there
> are just so many enums changed all at once.  I fear the day someone has
> a bug that bisects to this commit.
> 
> The difficult part was matching the changes in get_hash_params.py to the
> changes in mtypes.h.  It seems like modern C or C++ should have a way
> that we could let the compiler sort some of this out.  GCC has typeof(),
> but it looks like the equivalent things in Visual Studio are all
> run-time checks (typeid()) or deprecated (__typeof()).  Ugh.

C++11 has decltype(). It's supported by Visual Studio 2010 and later.

Fredrik



More information about the mesa-dev mailing list