[Mesa-dev] [PATCH] mesa: add AllowGLSLCrossStageInterpolationMismatch workaround

[Tapani Pälli]

On 11/23/2017 06:09 PM, Emil Velikov wrote:
> On 23 November 2017 at 05:54, Tapani Pälli <tapani.palli at intel.com> wrote:
>> This fixes issues seen with certain versions of Unreal Engine 4 editor
>> and games built with that using GLSL 4.30.
>>
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97852
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103801
>> ---
>>   src/compiler/glsl/link_varyings.cpp         | 51 +++++++++++++++++++----------
>>   src/gallium/include/state_tracker/st_api.h  |  1 +
>>   src/gallium/state_trackers/dri/dri_screen.c |  2 ++
>>   src/mesa/drivers/dri/i965/brw_context.c     |  3 ++
>>   src/mesa/drivers/dri/i965/intel_screen.c    |  1 +
>>   src/mesa/main/mtypes.h                      |  5 +++
>>   src/mesa/state_tracker/st_extensions.c      |  2 ++
>>   src/util/drirc                              |  8 +++++
>>   src/util/xmlpool/t_options.h                |  4 +++
> Without updating driinfo_gallium.h (see below), the existing st/mesa
> code will be a no-op.
> Personally I'll either add the missing hunk or simply drop the st/mesa bits.

Thanks, will add that. This was tested on gallium though so surely it 
must be doing something even without. Will send v2 in a minute.

> HTH
> Emil
> 
> --- a/src/gallium/auxiliary/pipe-loader/driinfo_gallium.h
> +++ b/src/gallium/auxiliary/pipe-loader/driinfo_gallium.h
> @@ -23,6 +23,7 @@ DRI_CONF_SECTION_DEBUG
>     DRI_CONF_FORCE_GLSL_VERSION(0)
>     DRI_CONF_ALLOW_GLSL_EXTENSION_DIRECTIVE_MIDSHADER("false")
>     DRI_CONF_ALLOW_GLSL_BUILTIN_VARIABLE_REDECLARATION("false")
> +   DRI_CONF_ALLOW_GLSL_CROSS_STAGE_INTERPOLATION_MISMATCH("false")
>     DRI_CONF_ALLOW_HIGHER_COMPAT_VERSION("false")
>     DRI_CONF_FORCE_GLSL_ABS_SQRT("false")
>     DRI_CONF_GLSL_CORRECT_DERIVATIVES_AFTER_DISCARD("false")
>