[Mesa-dev] [PATCH 1/3] util: Fix SHA1 implementation on big endian

Jon Turney jon.turney at dronecode.org.uk
Mon Nov 27 13:41:14 UTC 2017


On 26/11/2017 00:46, Matt Turner wrote:
> I've committed what I hope is the final fix.

After this series, if we are building on a target unknown to u_endian.h, 
so it can't determine the endianess, sha1.c now builds for big-endian.

This choice is made silently, but fortunately mesa-sha1_test fails when 
built for the wrong endianess, so there is some hope to notice this...



-------------- next part --------------
From e5c6197bdb4dec926ab31534b8533dd1bf14dfa1 Mon Sep 17 00:00:00 2001
From: Jon Turney <jon.turney at dronecode.org.uk>
Date: Mon, 27 Nov 2017 13:32:53 +0000
Subject: [PATCH] Also include endian.h on cygwin

If u_endian.h can't determine the endianess, the default behaviour in sha1.c
is to build for big-endian

Signed-off-by: Jon Turney <jon.turney at dronecode.org.uk>
---
 src/util/u_endian.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/u_endian.h b/src/util/u_endian.h
index 50f94c578ed..22d011ec008 100644
--- a/src/util/u_endian.h
+++ b/src/util/u_endian.h
@@ -27,7 +27,7 @@
 #ifndef U_ENDIAN_H
 #define U_ENDIAN_H
 
-#if defined(__GLIBC__) || defined(ANDROID)
+#if defined(__GLIBC__) || defined(ANDROID) || defined(__CYGWIN__)
 #include <endian.h>
 
 #if __BYTE_ORDER == __LITTLE_ENDIAN
-- 
2.15.0



More information about the mesa-dev mailing list