[Mesa-dev] [PATCH 2/5] meson: add Wundef to the build flags

[Dylan Baker]

This seems reasonable,
Reviewed-by: Dylan Baker <dylan at pnwbakers.com>

Quoting Emil Velikov (2017-11-24 06:25:03)
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> Analogous to the other build systems.
> 
> Cc: Eric Engestrom <eric.engestrom at imgtec.com>
> Cc: Dylan Baker <dylan at pnwbakers.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 53013e47ec4..2e704e18c93 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -468,7 +468,7 @@ endif
>  
>  # Check for generic C arguments
>  c_args = []
> -foreach a : ['-Wall', '-Werror=implicit-function-declaration',
> +foreach a : ['-Wall', '-Wundef', '-Werror=implicit-function-declaration',
>               '-Werror=missing-prototypes', '-fno-math-errno',
>               '-fno-trapping-math', '-Qunused-arguments']
>    if cc.has_argument(a)
> @@ -483,7 +483,7 @@ endif
>  # Check for generic C++ arguments
>  cpp = meson.get_compiler('cpp')
>  cpp_args = []
> -foreach a : ['-Wall', '-fno-math-errno', '-fno-trapping-math',
> +foreach a : ['-Wall', '-Wundef', '-fno-math-errno', '-fno-trapping-math',
>               '-Qunused-arguments', '-Wno-non-virtual-dtor']
>    if cpp.has_argument(a)
>      cpp_args += a
> -- 
> 2.14.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171127/0dbe8011/attachment.sig>