[Mesa-dev] [PATCH 1/2] docs/llvmpipe.html: Add ppc64le as alternative architecture to x86.

[Eric Engestrom]

On Monday, 2017-11-27 14:44:58 -0500, Ben Crocker wrote:
> Power8, Power8NV, and Power9 are supported on an equal footing
> with X86.
> 
> Cc: "17.2" "17.3" <mesa-stable at lists.freedesktop.org>
> Signed-off-by: Ben Crocker <bcrocker at redhat.com>
> ---
>  docs/llvmpipe.html | 20 ++++++++++++++++----
>  1 file changed, 16 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/llvmpipe.html b/docs/llvmpipe.html
> index 12dccb5eae..5f93c0b807 100644
> --- a/docs/llvmpipe.html
> +++ b/docs/llvmpipe.html
> @@ -20,7 +20,7 @@
>  The Gallium llvmpipe driver is a software rasterizer that uses LLVM to
>  do runtime code generation.
>  Shaders, point/line/triangle rasterization and vertex processing are
> -implemented with LLVM IR which is translated to x86 or x86-64 machine
> +implemented with LLVM IR which is translated to x86, x86-64, or ppc64le machine
>  code.
>  Also, the driver is multithreaded to take advantage of multiple CPU cores
>  (up to 8 at this time).
> @@ -32,18 +32,30 @@ It's the fastest software rasterizer for Mesa.
>  
>  <ul>
>  <li>
> -   <p>An x86 or amd64 processor; 64-bit mode recommended.</p>
> +   <p>For x86 or amd64 processors, 64-bit mode is recommended.</p>
>     <p>
>     Support for SSE2 is strongly encouraged.  Support for SSE3 and SSE4.1 will
>     yield the most efficient code.  The fewer features the CPU has the more
> -   likely is that you run into underperforming, buggy, or incomplete code.
> +   likely it is that you will run into underperforming, buggy, or incomplete code.

Pulled the second patch, with the above two fixes as well; thanks!

I don't know anything about PPC, so I'll let someone else confirm all
that before pulling, but it sounds reasonable.

>     </p>
> +</li>
> +<li>

Nit, but I don't think these should be different list items, but rather
simply different paragraphs in the same item.

> +   <p>
> +     For ppc64le processors, use of Altivec (the Vector Facility)
> +     is recommended if Altivec is supported.
> +   <p>
> +   </p>

These two lines need swapping as pointed out by Matt, or just removing;
not every sentence needs to be its own paragraph :P

> +     Use of VSX, the Vector-Scalar Facility, is recommended if VSX is supported,

Here and in the previous sentence, just say "if supported" instead of
repeating the name of the feature :)

> +     AND if LLVM version 4.0 or later is installed.
> +   </p>
> +</li>
> +<li>
>     <p>
>     See /proc/cpuinfo to know what your CPU supports.
>     </p>
>  </li>
>  <li>
> -   <p>LLVM: version 3.4 recommended; 3.3 or later required.</p>
> +   <p>Unless otherwise stated, LLVM version 3.4 is recommended; 3.3 or later is required.</p>
>     <p>
>     For Linux, on a recent Debian based distribution do:
>     </p>
> -- 
> 2.13.6
>