[Mesa-dev] [PATCH] mesa: Document ati_fragment_shader::cur_pass

[Roland Scheidegger]

Looks alright to me too. And it's shorter :-).

Roland

Am 28.11.2017 um 11:17 schrieb Miklós Máté:
> Hi,
> 
> I've already prepared a patch that documents this, I was going to post
> it with the v2 of this series. My version looks like this:
> 
> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> index 6b5c5bbb36..9c04a3c727 100644
> --- a/src/mesa/main/mtypes.h
> +++ b/src/mesa/main/mtypes.h
> @@ -2380,10 +2380,14 @@ struct ati_fragment_shader
>     GLubyte numArithInstr[2];
>     GLubyte regsAssigned[2];
>     GLubyte NumPasses;         /**< 1 or 2 */
> +   /** Current compile stage: 0 setup pass1, 1 arith pass1, 2 setup
> pass2, 3 arith pass2 */
>     GLubyte cur_pass;
>     GLubyte last_optype;
>     GLboolean interpinp1;
>     GLboolean isValid;
> +   /** Array of 2 bit values for each tex unit to remember whether
> +    * STR or STQ swizzle was used
> +    */
>     GLuint swizzlerq;
>     struct gl_program *Program;
>  };
> 
> MM
> 
> On 28/11/17 04:10, Ian Romanick wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
>> ---
>> Having this information would have helped me review recent patches from
>> Miklós...
>>
>>   src/mesa/main/mtypes.h | 10 +++++++++-
>>   1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
>> index 2f21633..e753438 100644
>> --- a/src/mesa/main/mtypes.h
>> +++ b/src/mesa/main/mtypes.h
>> @@ -2390,8 +2390,16 @@ struct ati_fragment_shader
>>      GLubyte numArithInstr[2];
>>      GLubyte regsAssigned[2];
>>      GLubyte NumPasses;         /**< 1 or 2 */
>> -   GLubyte cur_pass;
>> +
>> +   /**
>> +    * cur_pass distinguishes between the texture and arithmetic
>> phases.  There
>> +    * are a maximum of two passes, and each pass has a texture phase
>> followed
>> +    * by an arithmetic phase.  Hence cur_pass being 0 means currently
>> texture
>> +    * instructions are specified for the first pass. cur_pass 1
>> arithmetic for
>> +    * the first pass. cur_pass 2/3 correspond to the second pass
>> accordingly.
>> +    */
>>      GLubyte last_optype;
>> +
>>      GLboolean interpinp1;
>>      GLboolean isValid;
>>      GLuint swizzlerq;
> 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev