[Mesa-dev] [PATCH 3/6] i965: Preserve EXEC_OBJECT_CAPTURE when growing the BO.

[Ian Romanick]

This seems trivially correct, so this patch is

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

On 11/28/2017 04:13 PM, Kenneth Graunke wrote:
> The original state buffer was marked with EXEC_OBJECT_CAPTURE.  When
> growing it, we want to preserve that flag so we continue to capture it
> in GPU hang reports.
> 
> Fixes: 2dfc119f22f257082ab0 "i965: Grow the batch/state buffers if we need space and can't flush."
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103101
> ---
>  src/mesa/drivers/dri/i965/intel_batchbuffer.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_batchbuffer.c b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> index 2071faf85c2..a51905afdcc 100644
> --- a/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> +++ b/src/mesa/drivers/dri/i965/intel_batchbuffer.c
> @@ -322,9 +322,12 @@ grow_buffer(struct brw_context *brw,
>      * This guarantees that our relocations continue to work: values we've
>      * already written into the buffer, values we're going to write into the
>      * buffer, and the validation/relocation lists all will match.
> +    *
> +    * Also preserve kflags for EXEC_OBJECT_CAPTURE.
>      */
>     new_bo->gtt_offset = old_bo->gtt_offset;
>     new_bo->index = old_bo->index;
> +   new_bo->kflags = old_bo->kflags;
>  
>     /* Batch/state buffers are per-context, and if we've run out of space,
>      * we must have actually used them before, so...they will be in the list.