[Mesa-dev] [PATCH 0/6] i965: Fix texture_from_pixmap for CCS

[Jason Ekstrand]

On Tue, Nov 28, 2017 at 8:37 PM, Jason Ekstrand <jason at jlekstrand.net>
wrote:

> This series is one more go at fixing texture_from_pixmap.  The previous
> patches I apparently didn't test well enough because it regressed a bunch
> of tests when I ran it through Jenkins today.  These are all fixed by the
> new patch 1 and the corresponding hunk in patch 2.  I've also re-ordered
> things a bit so that "Pull the tex format from the renderbuffer in
> intelSetTexBuffer2" before "Reference the renderbuffer miptree in
> setTexBuffer2" to address some concerns from Chad
>

I should probably add that I don't really like the way my solution turned
out.  Unfortunately, the way miptrees work is kind-of a mess and I couldn't
really come up with a better way to let tex_obj->_Format differ from
mt->format other than to make it match the gl_texture_images.

--Jason


> Cc: Chad Versace <chadversary at chromium.org>
> Cc: Kenneth Graunke <kenneth at whitecape.org>
>
> Jason Ekstrand (6):
>   i965/miptree: Add a helper for getting the textureable format
>   i965/miptree: Loosen the format check in miptree_match_image
>   i965/tex_image: Pull the tex format from the renderbuffer in
>     intelSetTexBuffer2
>   i965/tex_image: Reference the renderbuffer miptree in setTexBuffer2
>   i965: Use finish_external instead of make_shareable in setTexBuffer2
>   intel/isl: Improve the documentation on get_default_aux_state
>
>  src/intel/isl/isl.h                              |  24 ++++-
>  src/mesa/drivers/dri/i965/brw_draw.c             |   3 +-
>  src/mesa/drivers/dri/i965/brw_wm_surface_state.c |  10 ++-
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c    |  57 +++++++++++-
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h    |   9 ++
>  src/mesa/drivers/dri/i965/intel_screen.c         |   2 +-
>  src/mesa/drivers/dri/i965/intel_tex.c            |   2 +-
>  src/mesa/drivers/dri/i965/intel_tex.h            |   2 +
>  src/mesa/drivers/dri/i965/intel_tex_image.c      | 107
> ++++++++++++++++++-----
>  src/mesa/drivers/dri/i965/intel_tex_obj.h        |   4 +-
>  src/mesa/drivers/dri/i965/intel_tex_validate.c   |   2 +-
>  11 files changed, 185 insertions(+), 37 deletions(-)
>
> --
> 2.5.0.400.gff86faf
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171128/83eecaac/attachment-0001.html>