[Mesa-dev] [PATCH 7/7] meson: fix deps and underlinkage of libGL

[Dylan Baker]

Quoting Jon Turney (2017-11-29 08:22:54)
> On 28/11/2017 18:21, Dylan Baker wrote:
> > Quoting Emil Velikov (2017-11-27 06:31:35)
> >> IIRC Windows mandates binaries with unresolved symbols.
> >> Other platforms allow such behaviour.
> >>
> >> I think we want to set b_lundef=true, to catch these issues as part of
> >> the build process.
> >> We already do so in the autotools, android and at least partially in scons.
> >>
> >> One would need a workaround for the sanitizers [1] analogous to our
> >> autotools and scons builds.
> >>
> >> Thanks for catching this Jon.
> >> -Emil
> >>
> >> [1] https://github.com/mesonbuild/meson/issues/764
> >> See commits 8b5d477aa820e52ed622c329933550c561ab1c93 and
> >> fa46848e51a619aba5a748316fe8fe4c2e17d243
> >> _______________________________________________
> >> mesa-dev mailing list
> >> mesa-dev at lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > 
> > JFYI,
> > 
> > b_lundef is true by default, and we don't override it. In this case (unless I'm
> > completely misreading/remembering [I wrote a very similar patch in my macos
> > branch]), the linkage is correct for Linux (possibly BSD too), but incorrect for
> > macOS, Cygwin, and Windows.
> 
> If this is the case, think this suggests that there's something 
> systematically wrong here, and this isn't the right fix...
> 
> I'll look into this a bit more.

I'm not sure there is anything wrong. with_dri_platfrom == 'drm' will always be
true on Linux/BSD, so really on Linux this patch has no functional changes, but
it will have functional changes in cases where with_dri_platform != 'drm', or am
I missing something?

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171129/8f1e747d/attachment.sig>