[Mesa-dev] [PATCH] Android: disable warnings causing errors

[Rob Herring]

On Wed, Nov 29, 2017 at 11:01 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 27 November 2017 at 19:36, Rob Herring <robh at kernel.org> wrote:
>> AOSP master has changed the build default to -Werror making all the
>> warnings errors. Override that with -Wno-error.
>>
> For both Mesa and libdrm patches
>
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>
> Mildly related:
> Quick grep|sort|unique through your build log shows the following.
> Some quick ideas, I haven't looked which one comes from where.

I have...

>
>       4 -Wdeprecated-declarations]
>      60 -Wdeprecated-register]

These are generated from bison, yacc or something. I'm not sure how to
fix. That's where I ran the other way.

>       6 -Wenum-conversion]
>       3 -Wformat]
> Should be trivial.
>
>      14 -Wmissing-braces]
> I'm fairly convinced this comes from the universal initializer {0}
> Just silence it?
>
>      44 -Wdelete-non-virtual-dtor]

I posted a patch a while back trying to fix this, but it actually
broke things at runtime.

>       4 -Wshift-negative-value]
>      20 -Wsometimes-uninitialized]
>       4 -Wuninitialized]
> Potential bugs, or compiler snafu?
>
>      52 -Wasm-operand-widths]
>       4 -Wconstant-logical-operand]
>      16 -Wgnu-variable-sized-type-not-at-end]
>       2 -Wmacro-redefined]
>      56 -Woverloaded-virtual]

Patch posted for these too.

>      26 -Wtautological-constant-out-of-range-compare]
>       1 -Wuser-defined-warnings]
> Meh?
>
> Addressing the [clang] mismatched-tags and toggling the warning back
> on shouldn't be too bad?

How many are clang/Android specific? It would be hopeless to re-enable
Werror if autotools/meson builds are not kept warning free. Maybe
those builds need to be stricter.

Rob