[Mesa-dev] [PATCH 1/2] glsl/es: precision qualifier doesn't need to match in UBOs

[Nicolai Hähnle]

On 09.11.2017 12:48, Samuel Iglesias Gonsálvez wrote:
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

Can you also update the comment? I can't quite match what the comment 
says to what the code does.

I think it should be something like:

"They might mismatch due to the two shaders using different GLSL 
versions, and that's ok in desktop GL. In ES, precision qualifiers
don't need to match."

If this understanding is correct and the comment added,

Reviewed-by: Nicolai Hähnle <nicolai.haehnle at amd.com>



> ---
>   src/compiler/glsl/link_interface_blocks.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/glsl/link_interface_blocks.cpp b/src/compiler/glsl/link_interface_blocks.cpp
> index 510d4f71bbe..c2c3b58f821 100644
> --- a/src/compiler/glsl/link_interface_blocks.cpp
> +++ b/src/compiler/glsl/link_interface_blocks.cpp
> @@ -114,7 +114,7 @@ intrastage_match(ir_variable *a,
>          */
>         if ((a->data.how_declared != ir_var_declared_implicitly ||
>              b->data.how_declared != ir_var_declared_implicitly) &&
> -          (!prog->IsES || prog->data->Version != 310 ||
> +          (!prog->IsES ||
>              interstage_member_mismatch(prog, a->get_interface_type(),
>                                         b->get_interface_type())))
>            return false;
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.