[Mesa-dev] [PATCH] egl/wayland: Don't use dmabuf with no modifiers

[Emil Velikov]

On 2 October 2017 at 16:55, Daniel Stone <daniels at collabora.com> wrote:
> The dmabuf interface requires a valid modifier to be sent. If we don't
> explicitly get a modifier from the driver, we can't know what to send;
> it must be inferred from legacy side-channels (or assumed to linear, if
> none exists).
>
> If we have no modifier, then we can only have a single-plane format
> anyway, so fall back to the old wl_drm buffer import path.
>
IIRC one my earlier questions was about this. The reply was that
dmabuf should work fine with single-plane formats.
Is that the root issue or it's the missing queryImage() error handling?

Can I suggest separating the two?

> Fixes: a65db0ad1c ("st/dri: don't expose modifiers in EGL if the driver doesn't implement them")
I think this should be
Fixes: 02cc3593727 ("egl/wayland: Use linux-dmabuf interface for buffers")

Thanks
Emil