[Mesa-dev] [PATCH 05/15] mesa: Remove fprintf referring to libdxtn

Matt Turner mattst88 at gmail.com
Mon Oct 2 17:07:56 UTC 2017


On Mon, Oct 2, 2017 at 4:20 AM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> On 02.10.2017 08:59, Matt Turner wrote:
>>
>> When this file is included by Gallium, the fprintf causes it to fail to
>> compile. This is an unreachable error case, and we shouldn't be calling
>> fprintf directly.
>> ---
>>   src/mesa/main/texcompress_s3tc_tmp.h | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/src/mesa/main/texcompress_s3tc_tmp.h
>> b/src/mesa/main/texcompress_s3tc_tmp.h
>> index 3abce6e904..4fec4a6b4a 100644
>> --- a/src/mesa/main/texcompress_s3tc_tmp.h
>> +++ b/src/mesa/main/texcompress_s3tc_tmp.h
>> @@ -983,7 +983,6 @@ static void tx_compress_dxtn(GLint srccomps, GLint
>> width, GLint height, const GL
>>         }
>>         break;
>>      default:
>> -      fprintf(stderr, "libdxtn: Bad dstFormat %d in tx_compress_dxtn\n",
>> destFormat);
>
>
> Maybe replace by an assert(false);?

Sure. Thanks!


More information about the mesa-dev mailing list