[Mesa-dev] [PATCH 10/15] gallium: Remove util_format_s3tc_enabled

[Roland Scheidegger]

Am 02.10.2017 um 19:36 schrieb Emil Velikov:
> On 2 October 2017 at 18:15, Matt Turner <mattst88 at gmail.com> wrote:
>> On Mon, Oct 2, 2017 at 6:17 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> On 2 October 2017 at 07:59, Matt Turner <mattst88 at gmail.com> wrote:
>>>
>>>> +#include "../../../mesa/main/texcompress_s3tc_tmp.h"
>>>>
>>> This feels a bit dirty. If people are not too keen on the idea,
>>> another approach is to have the code in src/util/
>>
>> This is how the ETC code is handled as well:
>>
>> src/gallium/auxiliary/util/u_format_etc.c:#include
>> "../../../mesa/main/texcompress_etc_tmp.h"
> 
> Hmm did not see that one - never mind me then.
>

I can't comment on the patch, but including things like that is indeed
dirty. But since there's precedence...

Roland