[Mesa-dev] [PATCH 2/2] anv: Remove unreachable cases from isl_format_for_size()

Lionel Landwerlin lionel.g.landwerlin at intel.com
Mon Oct 2 19:12:11 UTC 2017


Make sense, if you could just update the comment in the unreachable(), 
should be multiple of 4.
With that changed :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com

On 02/10/17 18:58, Józef Kucia wrote:
> The dstOffset and fillSize parameters must be multiple of 4.
> ---
>   src/intel/vulkan/anv_blorp.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_blorp.c b/src/intel/vulkan/anv_blorp.c
> index a8ebdb384c..8dead1d87a 100644
> --- a/src/intel/vulkan/anv_blorp.c
> +++ b/src/intel/vulkan/anv_blorp.c
> @@ -531,8 +531,6 @@ static enum isl_format
>   isl_format_for_size(unsigned size_B)
>   {
>      switch (size_B) {
> -   case 1:  return ISL_FORMAT_R8_UINT;
> -   case 2:  return ISL_FORMAT_R8G8_UINT;
>      case 4:  return ISL_FORMAT_R32_UINT;
>      case 8:  return ISL_FORMAT_R32G32_UINT;
>      case 16: return ISL_FORMAT_R32G32B32A32_UINT;




More information about the mesa-dev mailing list