[Mesa-dev] [PATCH 3/3] nv50, nvc0/ir: Display shared memory usage in pipe_debug_message

[Pierre Moreau]

On 2017-10-02 — 19:24, Ilia Mirkin wrote:
> Looks like this will upset my parser which is the only consumer of this info:
> 
> https://cgit.freedesktop.org/mesa/shader-db/tree/nv-report.py
> 
> Should be doable to rewrite it to not care about order. Or stick your
> new thing at the end. Either way.

I placed it there to group it with other memory storage information such as
local, and gpr in some way.
I’ll send a patch to update nv-report (to which ML should I send it?).

> On Mon, Oct 2, 2017 at 2:57 PM, Pierre Moreau <pierre.morrow at free.fr> wrote:
> > Signed-off-by: Pierre Moreau <pierre.morrow at free.fr>
> > ---
> >  src/gallium/drivers/nouveau/nv50/nv50_program.c | 7 ++++---
> >  src/gallium/drivers/nouveau/nvc0/nvc0_program.c | 7 ++++---
> >  2 files changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/src/gallium/drivers/nouveau/nv50/nv50_program.c b/src/gallium/drivers/nouveau/nv50/nv50_program.c
> > index 6b472d7fdd..6e943a3d94 100644
> > --- a/src/gallium/drivers/nouveau/nv50/nv50_program.c
> > +++ b/src/gallium/drivers/nouveau/nv50/nv50_program.c
> > @@ -431,9 +431,10 @@ nv50_program_translate(struct nv50_program *prog, uint16_t chipset,
> >                                                     &prog->pipe.stream_output);
> >
> >     pipe_debug_message(debug, SHADER_INFO,
> > -                      "type: %d, local: %d, gpr: %d, inst: %d, bytes: %d",
> > -                      prog->type, info->bin.tlsSpace, prog->max_gpr,
> > -                      info->bin.instructions, info->bin.codeSize);
> > +                      "type: %d, local: %d, shared: %d, gpr: %d, inst: %d, bytes: %d",
> > +                      prog->type, info->bin.tlsSpace, info->bin.smemSize,
> > +                      prog->max_gpr, info->bin.instructions,
> > +                      info->bin.codeSize);
> >
> >  out:
> >     FREE(info);
> > diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_program.c b/src/gallium/drivers/nouveau/nvc0/nvc0_program.c
> > index a6112f401e..c95a96c717 100644
> > --- a/src/gallium/drivers/nouveau/nvc0/nvc0_program.c
> > +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_program.c
> > @@ -684,9 +684,10 @@ nvc0_program_translate(struct nvc0_program *prog, uint16_t chipset,
> >                                                  &prog->pipe.stream_output);
> >
> >     pipe_debug_message(debug, SHADER_INFO,
> > -                      "type: %d, local: %d, gpr: %d, inst: %d, bytes: %d",
> > -                      prog->type, info->bin.tlsSpace, prog->num_gprs,
> > -                      info->bin.instructions, info->bin.codeSize);
> > +                      "type: %d, local: %d, shared: %d, gpr: %d, inst: %d, bytes: %d",
> > +                      prog->type, info->bin.tlsSpace, info->bin.smemSize,
> > +                      prog->num_gprs, info->bin.instructions,
> > +                      info->bin.codeSize);
> >
> >  #ifdef DEBUG
> >     if (debug_get_option("NV50_PROG_CHIPSET", NULL) && info->dbgFlags)
> > --
> > 2.14.2
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171003/fb21ccdf/attachment.sig>