[Mesa-dev] [PATCH] wayland-egl: forward declare wl_egl_window* functions

Tobias Klausmann tobias.johannes.klausmann at mni.thm.de
Tue Oct 3 13:43:27 UTC 2017


On 10/3/17 3:37 PM, Emil Velikov wrote:
> On 3 October 2017 at 14:34, Tobias Klausmann
> <tobias.johannes.klausmann at mni.thm.de> wrote:
>> Starting with commit ab0589c6ed ("wayland-egl: remove no longer needed
>> wayland-client dependency") the wayland-egl.h include was missing leading to a
>> build failure:
>>
>>   CC       wayland-egl.lo
>> wayland-egl.c:33:10: fatal error: wayland-egl.h: No such file or directory
>>  #include "wayland-egl.h"
>>           ^~~~~~~~~~~~~~~
>>
>> This commit forward declares the following 4 functions from wayland-egl-core.h,
>> as suggested by Andres Gomez:
>>  * wl_egl_window_resize
>>  * wl_egl_window_create
>>  * wl_egl_window_destroy
>>  * wl_egl_window_get_attached_size
>>
>> With this we can drop the wayland-egl.h include!
>>
>> Fixes: ab0589c6ed ("wayland-egl: remove no longer needed wayland-client
>> dependency")
>> Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
>> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> Apologies, I should have made this clearer:
> Your original patch was good enough for now. This approach will
> conflict (badly) with the move/import plan mentioned.
>
> Thanks
> Emil


No problem, i will send the other one with the small fixes, i can not
commit it though,

Tobias



More information about the mesa-dev mailing list