[Mesa-dev] [PATCH v2 1/2] egl/wayland: Check queryImage return for wl_buffer

[Marek Olšák]

On Mon, Oct 2, 2017 at 8:09 PM, Daniel Stone <daniel at fooishbar.org> wrote:
> On 2 October 2017 at 18:34, Daniel Stone <daniel at fooishbar.org> wrote:
>> Marek, Michel, any ideas? Looks like the winsys buffers we create lose
>> all their tiling information between client and KMS. You can test it
>> just by running 'weston-simple-egl -f', with whatever version of
>> Weston, and the two patches in this thread.
>
> Perhaps unsurprisingly, adding __DRI_IMAGE_USE_SCANOUT to
> src/egl/drivers/dri2/platform_wayland.c in the createImage() fallback
> path (i.e. not createImageWithModifiers) fixes things. That being
> said, Weston does do the GBM BO import with the scanout flag, which
> will call the DRIImage's validateUsage() hook with the SCANOUT bit
> set; for now, it should be enough to just detect that the image is not
> scanout-compatible in radeonsi's validateUsage() hook, rejecting the
> import which will make Weston fall back to GLES composition.
>
> That being said, st/dri's dri2_validate_usage() doesn't really fill me
> with too much confidence.

We don't really validate flags during DMABUF import. The idea is that
all clients should know the flags since buffer creation, and have no
reason to pass different flags during the import.

Marek