[Mesa-dev] [PATCH v2 3/7] travis: Add clover build using llvm-3.7

[Eric Engestrom]

On Tuesday, 2017-10-03 12:28:54 -0400, Jan Vesely wrote:
> On Tue, 2017-10-03 at 17:26 +0100, Eric Engestrom wrote:
> > On Friday, 2017-09-29 16:32:36 +0000, Jan Vesely wrote:
> > > On Mon, 2017-09-18 at 16:46 +0100, Eric Engestrom wrote:
> > > > On Monday, 2017-09-18 11:10:37 -0400, Jan Vesely wrote:
> > > > > On Mon, 2017-09-18 at 11:13 +0100, Eric Engestrom wrote:
> > > > > > On Sunday, 2017-09-17 02:02:33 -0400, Jan Vesely wrote:
> > > > > > > v2: Use direct llvm repo link instead of alias
> > > > > > >     Enable
> > > > > > > 
> > > > > > > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > > > > > > ---
> > > > > > >  .travis.yml | 40 ++++++++++++++++++++++++++++++++++++++++
> > > > > > >  1 file changed, 40 insertions(+)
> > > > > > > 
> > > > > > > diff --git a/.travis.yml b/.travis.yml
> > > > > > > index 0012d27dc7..638ec2a78a 100644
> > > > > > > --- a/.travis.yml
> > > > > > > +++ b/.travis.yml
> > > > > > > @@ -152,6 +152,46 @@ matrix:
> > > > > > >              - libelf-dev
> > > > > > >              - libunwind8-dev
> > > > > > >      - env:
> > > > > > > +        # Disable for now since travis does not allow llvm-toolchain-trusty-3.7
> > > > > > 
> > > > > > You can drop this line now :)
> > > > > 
> > > > > Fixed locally.
> > > > > 
> > > > > > 
> > > > > > Don't 4.0 and 5.0 need the same binutils-2.26 as 3.9?
> > > > 
> > > > You didn't answer this; isn't it needed?
> > > > 
> > > > > > Speaking of, I think the OVERRIDE_PATH you added is the only way to do this.
> > > > > > 
> > > > > > With the above fixed or justified, the series is:
> > > > > > Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
> > > > > 
> > > > > thanks.
> > > > > 
> > > > > > 
> > > > > > One thing before anyone pushes this however: this will make the builds
> > > > > > much longer; is the gain of testing every supported llvm version worth it?
> > > > > 
> > > > > It does not really make builds that much worse after the ccache has
> > > > > warmed up:
> > > > > https://travis-ci.org/jvesely/mesa/builds/276686220
> > > > > building SWR is the elephant and it leaves time to build these in
> > > > > parallel.
> > > > 
> > > > Looking at the numbers, I'm convinced :)
> > > > Do you have push access, or do you want me to push the series for you?
> > > > 
> > > > (Note: typo in the subject of patch 6/7)
> > > 
> > > sorry, I missed this part the first time.
> > > I've fixed the typo in patch 6 and pushed patches 5/6/7 per discussion
> > > with Emil.
> > 
> > Don't we want to drop the 3.6 build then?
> 
> I've left it for Emil to remove in the same patch(or series) that drops
> clover llvm<3.9 support. seemed like a good idea to keep around until
> then.

Very good point :)
I'll leave it alone.

> 
> Jan
>