[Mesa-dev] [PATCH v2 03/11] isl: fill out layout descriptions for yuv formats
Lionel Landwerlin
lionel.g.landwerlin at intel.com
Tue Oct 3 17:24:58 UTC 2017
On 03/10/17 18:09, Chad Versace wrote:
> On Tue 03 Oct 2017, Lionel Landwerlin wrote:
>> Some description was missing.
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> ---
>> src/intel/isl/isl_format_layout.csv | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/intel/isl/isl_format_layout.csv b/src/intel/isl/isl_format_layout.csv
>> index f340e30a1bf..ebb3d22bc18 100644
>> --- a/src/intel/isl/isl_format_layout.csv
>> +++ b/src/intel/isl/isl_format_layout.csv
>> @@ -222,8 +222,8 @@ I8_UINT , 8, 1, 1, 1, , , , , , ui
>> I8_SINT , 8, 1, 1, 1, , , , , , si8, , linear,
>> DXT1_RGB_SRGB , 64, 4, 4, 1, un4, un4, un4, , , , , srgb, dxt1
>> R1_UNORM , 1, 1, 1, 1, un1, , , , , , , linear,
>> -YCRCB_NORMAL , 0, 0, 0, 0, , , , , , , , yuv,
>> -YCRCB_SWAPUVY , 0, 0, 0, 0, , , , , , , , yuv,
>> +YCRCB_NORMAL , 16, 1, 1, 1, un8, un8, un8, , , , , yuv,
>> +YCRCB_SWAPUVY , 16, 1, 1, 1, un8, un8, un8, , , , , yuv,
> If you override the meaning of the rgb channels when colorspace == yuv,
> then you must also update any code that makes decisions by inspecting
> the rgb channels but neglects to inspect the colorspace. As far as I can
> tell, the only code that needs updating is the body of
> isl_format_is_rgb().
>
> Other than that, overrideing the channels here looks good to me.
>
Thanks,
Feels like it should almost have its own patch.
More information about the mesa-dev
mailing list