[Mesa-dev] [PATCH v2 01/11] vulkan: util: add macros to extract extension/offset number from enums

[Chad Versace]

On Tue 03 Oct 2017, Jason Ekstrand wrote:
> 
> On Tue, Oct 3, 2017 at 3:18 PM, Lionel Landwerlin <[1]
> lionel.g.landwerlin at intel.com> wrote:
> 
>     On 03/10/17 21:21, Chad Versace wrote:
> 
>         On Tue 03 Oct 2017, Lionel Landwerlin wrote:
> 
>             On 03/10/17 19:13, Jason Ekstrand wrote:
> 
>                  +1 to static inline
> 
>             Done locally.
> 
>         Cool. Waiting to see it appear in wip/djeath/ycbcr_conversion.
> 
> 
>     Ah...
>     I didn't actually test that (with all the other commits on top).
> 
>     Unfortunately that's breaking a bit the way we index formats :
> 
>     [4]https://github.com/djdeath/mesa/blob/wip/djdeath/ycbcr_conversion/src/
>     intel/vulkan/anv_formats.c#L49
> 
> 
> Right... That's a bummer.  Macros it is, I guess.

Fair enough. But please make the macros uppercase, so no one is hurt by
the multiple evaluation.