[Mesa-dev] [PATCH 1/2] wayland-drm: use a copy of the wayland_drm_callbacks struct

Daniel Stone daniel at fooishbar.org
Wed Oct 4 10:46:37 UTC 2017


Hi Emil,

On 27 September 2017 at 19:49, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> The callbacks may be called even when they are no longer valid.
> Say, the user is dlclose(ing) libEGL while the buffers are being
> destroyed.

Series looks good to me, but if the user calls dlclose on EGL or
whatever before the display/surface/buffers have all been destroyed,
we're screwed anyway, since the authenticate callback will still point
into oblivion. So the commit message probably needs some rework.
Regardless:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the mesa-dev mailing list