[Mesa-dev] [PATCH v3 13/22] egl: add dri2_egl_surface_destroy_image_front() helper
robh at kernel.org
Wed Oct 4 14:35:15 UTC 2017
On Wed, Oct 4, 2017 at 9:02 AM, Rob Herring <robh at kernel.org> wrote:
> On Wed, Oct 4, 2017 at 1:50 AM, Gwan-gyeong Mun <elongbug at gmail.com> wrote:
>> To share common destroy dri_image_front code.
>> Signed-off-by: Mun Gwan-gyeong <elongbug at gmail.com>
>> src/egl/drivers/dri2/egl_dri2.c | 14 ++++++++++++++
>> src/egl/drivers/dri2/egl_dri2.h | 3 +++
>> 2 files changed, 17 insertions(+)
>> diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
>> index e13b13c282..4070a80b23 100644
>> --- a/src/egl/drivers/dri2/egl_dri2.c
>> +++ b/src/egl/drivers/dri2/egl_dri2.c
>> @@ -1153,6 +1153,20 @@ dri2_egl_surface_destroy_image_back(struct dri2_egl_surface *dri2_surf)
>> +dri2_egl_surface_destroy_image_front(struct dri2_egl_surface *dri2_surf)
>> +#if defined(HAVE_ANDROID_PLATFORM) || defined(HAVE_TIZEN_PLATFORM)
> It seems this function only gets called from the Android and Tizen
> specific code, so you don't need the #ifdef.
> Plus you can probably also rely on dri_image_front being NULL for
> other platforms.
NM, I guess it is needed as dri_image_front is still conditional.
Perhaps it should not be?
More information about the mesa-dev