[Mesa-dev] [PATCH v2 09/11] anv: add nir lowering pass for ycrcb textures

Lionel Landwerlin lionel.g.landwerlin at intel.com
Wed Oct 4 15:03:05 UTC 2017


On 04/10/17 00:58, Jason Ekstrand wrote:
>
>
>         +   struct ycbcr_state state = {
>         +      .builder = builder,
>         +      .origin_tex = tex,
>         +      .conversion = sampler->conversion,
>
>
> What about arrays of samplers?  You're not allowed to indirect on them 
> but they can, in theory, exist and have different samplers with 
> different conversions.  I think we need to fish the array index out 
> and take sampler[idx].conversion here instead.

Thanks, need to do that indeed.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171004/51e7e9fb/attachment.html>


More information about the mesa-dev mailing list