[Mesa-dev] [PATCH 6/6] meson: build classic swrast

[Eric Anholt]

Dylan Baker <dylan at pnwbakers.com> writes:

> This adds support for building the classic swrast implementation. This
> driver has been tested with glxinfo and glxgears.
>
> Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> ---
>  meson.build                                   |  2 ++
>  meson_options.txt                             |  2 +-
>  src/mesa/drivers/dri/meson.build              |  5 +++
>  src/mesa/drivers/dri/{ => swrast}/meson.build | 45 +++++----------------------
>  4 files changed, 16 insertions(+), 38 deletions(-)
>  copy src/mesa/drivers/dri/{ => swrast}/meson.build (52%)
>

> diff --git a/src/mesa/drivers/dri/meson.build b/src/mesa/drivers/dri/meson.build
> index f7403ec09fc..153aa15efb6 100644
> --- a/src/mesa/drivers/dri/meson.build
> +++ b/src/mesa/drivers/dri/meson.build
> @@ -19,11 +19,16 @@
>  # SOFTWARE.
>  
>  subdir('common')
> +subdir('swrast')
>  subdir('i965')
>  
>  if with_dri
>    dri_drivers = []
>    dri_link = []
> +  if with_dri_swrast
> +    dri_drivers += libswrast_dri
> +    dri_link += 'swrast_dri.so'
> +  endif
>    if with_dri_i965
>      dri_drivers += libi965
>      dri_link += 'i965_dri.so'

General style suggestion for this and i965: Define these two variables
before the subdir(driver), conditionally go into the subdir, and have
the driver just append itself to the array.  Then you don't need
build_by_default flags on the driver's libs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171004/fa82d226/attachment.sig>