[Mesa-dev] [PATCH] egl: Simplify the "driver" interface

Eric Anholt eric at anholt.net
Thu Oct 5 17:17:46 UTC 2017


Adam Jackson <ajax at redhat.com> writes:

> "Driver" isn't a great word for what this layer is, it's effectively a
> build-time choice about what OS you're targeting. Despite that both of
> the extant backends totally ignore the display argument, the old code
> would only set up the backend relative to a display.
>
> That causes problems! One problem is it means eglGetProcAddress can
> generate X or Wayland protocol when it tries to connect to a default
> display so it can call into the backend, which is, you know, completely
> bonkers. Any other EGL API that doesn't reference a display, like
> EGL_EXT_device_query, would have the same issue.
>
> Fortunately this is a problem that can be solved with the delete key.
>
> Signed-off-by: Adam Jackson <ajax at redhat.com>

Reviewed-by: Eric Anholt <eric at anholt.net>

Can we garbage collect the "args" argument to the init func, too?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171005/f2af174b/attachment.sig>


More information about the mesa-dev mailing list