[Mesa-dev] [PATCH] egl: Simplify the "driver" interface

Emil Velikov emil.l.velikov at gmail.com
Thu Oct 5 17:51:02 UTC 2017


On 5 October 2017 at 17:42, Adam Jackson <ajax at redhat.com> wrote:
> "Driver" isn't a great word for what this layer is, it's effectively a
> build-time choice about what OS you're targeting. Despite that both of
> the extant backends totally ignore the display argument, the old code
> would only set up the backend relative to a display.
>
> That causes problems! One problem is it means eglGetProcAddress can
> generate X or Wayland protocol when it tries to connect to a default
> display so it can call into the backend, which is, you know, completely
> bonkers. Any other EGL API that doesn't reference a display, like
> EGL_EXT_device_query, would have the same issue.
>
EGL_DRIVER is quite misleading indeed. The fun things people have
tried to do with it.

With this patch in mind, we cannot have dri2 and haiku in the same binary.
Not that makes much sense, but please mention it in the commit
summary. That or preserve the separate function names.

With that
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

As Eric mentioned - there's more cleanups that can be done, say purge
the _EGL_BUILT_IN_DRIVER_* bits.
But that can happen at a later stage.

Thanks
Emil


More information about the mesa-dev mailing list