[Mesa-dev] [PATCH v2 01/12] make: change include to work for meson

[Dylan Baker]

Quoting Emil Velikov (2017-10-05 11:17:06)
> On 5 October 2017 at 18:12, Dylan Baker <dylan at pnwbakers.com> wrote:
> > Meson expects you to include the generated target in another target's
> > sources, and it will generate the include directives for you, so change
> > the source file and add the generated glx builddir to the autotools
> > include to make that work.
> >
> While correct, all of this is orthogonal to the issue.
> 
> 
> Traversing back through includes is bad idea and should be avoided.
> In the case here - indirect_size.h is located in the build directory
> $(top_builddir)/src/glx/.
> 
> Add the include and adjust the include path of the file.
> 
> 
> >         -I$(top_srcdir)/src/glx \
> > +       -I$(top_builddir)/src/glx \
> builddir before srcdir,
> 
> 
> With the above fix and alternative commit message (feel free to reuse
> as much or as little or my wording):
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Thanks
> Emil

Done. I pulled in your message too, and cut the meson message down to small
aside.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171005/4086a30f/attachment-0001.sig>