[Mesa-dev] [PATCH v2 06/12] meson: Build i965 and dri stack

[Dylan Baker]

Quoting Eric Anholt (2017-10-05 12:57:41)
> Dylan Baker <dylan at pnwbakers.com> writes:
> 
> > This gets pretty much the entire classic tree building, as well as
> > i965, including the various glapis. There are some workarounds for bugs
> > that are fixed in meson 0.43.0, which is due out on October 8th.
> >
> > I have tested this with piglit using glx.
> >
> > v2: - fix typo "vaule" -> "value"
> >     - use gtest dep instead of linking to libgtest (rebase error)
> >     - use gtest dep instead of linking against libgtest (rebase error)
> >     - copy the megadriver, then create hard links from that, then delete
> >       the megadriver. This matches the behavior of the autotools build.
> >       (Eric A)
> >     - Use host_machine instead of target_machine (Eric A)
> >     - Put a comment in the right place (Eric A)
> >     - Don't have two variables for the same information (Eric A)
> >     - Put pre_args at top of file in this patch (Eric A)
> >     - Fix glx generators in this patch instead of next (Eric A)
> >     - Remove -DMESON hack (Eric A)
> >     - add sha1_h to mesa in this patch (Eric A)
> >     - Put generators in loops when possible to reduce code in
> >       mapi/glapi/gen (Eric A)
> >
> > Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> 
> > +pkg.generate(
> > +  libraries : libglesv1_cm,
> > +  # TODO: private libraries?
> > +  name : 'glesv1_cm',
> > +  version : meson.project_version(),
> > +  description : 'Mesa OpenGL ES 1.1 CM library',
> > +  filebase : 'glesv1_cm'
> > +)
> 
> I'd like to make sure we get these right, since our piglit/cts runs
> won't tell us if we screw it up.  Looks like we want libraries_private:
> m_dep, dl_dep, dep_thread.  Same for glesv2.

Okay. Currently that means passing strings to those arguments, and I couldn't
find any clever way to tease the dependency/library objects to to produce
strings, so I hadn't done that yet.. I have a meson branch that allows passing
dependency objects as well, but meson is in feature freeze for 0.43 (on the
8th), nirbheek suggested that we could actually just get that information from
the arguments to libraries as well. So I'll work on getting one of those two
features upstream so we can forget about setting *_private.

Dylan

> 
> With that fixed, I'd give it:
> 
> Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171005/d0c1d9b1/attachment.sig>