[Mesa-dev] [PATCH v2 05/12] meson: de-tabularize meson_options.txt

[Dylan Baker]

Quoting Eero Tamminen (2017-10-06 03:22:56)
> Hi,
> 
> On 05.10.2017 20:12, Dylan Baker wrote:
> > This ends up being unworkable as more options get added, and with
> > description wrapped onto a new line it doesn't improve readability
> > anyway.
> > 
> > Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
> > ---
> >   meson_options.txt | 12 ++++++------
> >   1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/meson_options.txt b/meson_options.txt
> > index eccd5c10d59..6ca19db3497 100644
> > --- a/meson_options.txt
> > +++ b/meson_options.txt
> > @@ -18,15 +18,15 @@
> >   # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> >   # SOFTWARE.
> >   
> > -option('platforms',      type : 'string',  value : 'x11,wayland',
> > +option('platforms', type : 'string', value : 'x11,wayland',
> >          description : 'comma separated list of window systems to support. wayland, x11, surfaceless, drm, etc.')
> > -option('vulkan-drivers', type : 'string',  value : 'intel,amd',
> > +option('vulkan-drivers', type : 'string', value : 'intel,amd',
> >          description : 'comma separated list of vulkan drivers to build.')
> 
> Would this work visually better like this:
> 
> option('platforms',
>         type  : 'string',
>         value : 'x11,wayland',
>         description : 'comma separated list of window systems to 
> support. wayland, x11, surfaceless, drm, etc.'
> )
> 
> option('vulkan-drivers',
>         type  : 'string',
>         value : 'intel,amd',
>         description : 'comma separated list of vulkan drivers to build.'
> )
> 
> ?
> 
>         - Eero

It probably would, at this point though if possible I'd rather do that as a
follow up, it creates a lot of rebasing to alter this file this early in the
series.

Dylan

> 
> > -option('shader-cache',    type : 'boolean', value : true,
> > +option('shader-cache', type : 'boolean', value : true,
> >          description : 'Build with on-disk shader cache support')
> > -option('vulkan-icd-dir', type : 'string',  value : '',
> > +option('vulkan-icd-dir', type : 'string', value : '',
> >          description : 'Location relative to prefix to put vulkan icds on install. Default: $datadir/vulkan/icd.d')
> > -option('valgrind',       type : 'boolean', value : true,
> > +option('valgrind', type : 'boolean', value : true,
> >          description : 'Build with valgrind support if possible')
> > -option('build-tests',    type : 'boolean', value : false,
> > +option('build-tests', type : 'boolean', value : false,
> >          description : 'Build unit tests. Currently this will build *all* unit tests, which may build more than expected.')
> > 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171006/c1eda488/attachment.sig>