[Mesa-dev] [PATCH] mesa: Use immutable level count in FramebufferTexture error check.
kenneth at whitecape.org
Sat Oct 7 20:38:07 UTC 2017
On Saturday, October 7, 2017 6:30:38 AM PDT Ilia Mirkin wrote:
> Hi Ken,
> Have a look at
> No idea what the outcome of that was. I guess some code reorg has
> happened since too. If, after reading through those, you think this is
> right - go ahead :) I've lost all context on this.
I went back through the history and discovered that you, Antia, and I
all independently wrote basically the same patch.
Nicolai pointed out that the GL 4.6 specification now has a quote
making this clearly the right behavior, so it's no longer ambiguous.
I think this was added after Antia noticed that ES 3.2 had text for
this and filed a bug about GL 4.5 with Khronos.
Antia decided at one point that using ImmutableLevels was the right
thing to do, which I agree with. The new spec makes this very clear.
So, time to finally land the fix. I just pushed a patch. I kept my
code (as it applies to today's Mesa), but added the spec quote from
Nicolai, updated it to reuse some of your commit message, and added
Antia's R-b from a previous iteration of this patch.
Thank you all for your hard work tracking this down over the last
10 months :)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: This is a digitally signed message part.
More information about the mesa-dev