[Mesa-dev] [PATCH 3/6] mesa/st/glsl_to_tgsi: Add tracking of ifelse writes in register merging

Nicolai Hähnle nhaehnle at gmail.com
Mon Oct 9 14:53:58 UTC 2017


On 04.10.2017 11:45, Gert Wollny wrote:
> +   int write_unconditional_in_loop_id;
> +   unsigned int if_write_flags;
> +   int next_ifelse_nesting_depth; > +
> +   bool else_write;

I kind of hoped you learned the lesson from last time that you really 
need to document your data for algorithms like this. I'm not going to 
review this patch unless you fix that.

Cheers,
Nicolai
-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list