[Mesa-dev] [PATCH 2/2] i965: silence coverity warning

Antia Puentes apuentes at igalia.com
Mon Oct 9 14:58:53 UTC 2017


Reviewed-by: Antia Puentes <apuentes at igalia.com>


On 09/10/17 16:37, Lionel Landwerlin wrote:
> Also makes this statement a bit clearer.
>
> CID: 1418920
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>   src/mesa/drivers/dri/i965/brw_draw.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
> index c7ed7284501..7ebed98fcef 100644
> --- a/src/mesa/drivers/dri/i965/brw_draw.c
> +++ b/src/mesa/drivers/dri/i965/brw_draw.c
> @@ -955,7 +955,7 @@ brw_draw_indirect_prims(struct gl_context *ctx,
>      prim[draw_count - 1].end = 1;
>      for (i = 0; i < draw_count; ++i, indirect_offset += stride) {
>         prim[i].mode = mode;
> -      prim[i].indexed = !!ib;
> +      prim[i].indexed = ib != NULL;
>         prim[i].indirect_offset = indirect_offset;
>         prim[i].is_indirect = 1;
>         prim[i].draw_id = i;



More information about the mesa-dev mailing list