[Mesa-dev] [PATCH] anv: Do not assert() on VK_ATTACHMENT_UNUSED

Jason Ekstrand jason at jlekstrand.net
Mon Oct 9 23:29:25 UTC 2017


I just pushed this and the SPIR-V patch.  Thanks!

On Mon, Oct 9, 2017 at 2:13 PM, Nanley Chery <nanleychery at gmail.com> wrote:

> On Mon, Oct 09, 2017 at 10:42:06PM +0200, Józef Kucia wrote:
> > ---
> >  src/intel/vulkan/genX_cmd_buffer.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
>
> This patch is
> Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
>
> > diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> > index 93d360a1bb..43437c8eb0 100644
> > --- a/src/intel/vulkan/genX_cmd_buffer.c
> > +++ b/src/intel/vulkan/genX_cmd_buffer.c
> > @@ -2996,10 +2996,11 @@ cmd_buffer_subpass_sync_fast_clear_values(struct
> anv_cmd_buffer *cmd_buffer)
> >         * render pass and used in the subpass.
> >         */
> >        const uint32_t a = state->subpass->color_
> attachments[i].attachment;
> > -      assert(a < state->pass->attachment_count);
> >        if (a == VK_ATTACHMENT_UNUSED)
> >           continue;
> >
> > +      assert(a < state->pass->attachment_count);
> > +
> >        /* Store some information regarding this attachment. */
> >        const struct anv_attachment_state *att_state =
> &state->attachments[a];
> >        const struct anv_image_view *iview = state->framebuffer->
> attachments[a];
> > --
> > 2.13.6
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20171009/d9b5b8b5/attachment.html>


More information about the mesa-dev mailing list